Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add readme to divan_compat #75

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: add readme to divan_compat #75

merged 1 commit into from
Feb 13, 2025

Conversation

GuillaumeLagrange
Copy link
Contributor

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 12, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #75 will not alter performance

Comparing add-divan-todo (fd8f45d) with main (38f7270)

Summary

✅ 152 untouched benchmarks

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 12, 2025 •
edited
Loading

CodSpeed Walltime Performance Report

Merging #75 will degrade performances by 13.15%

Comparing add-divan-todo (fd8f45d) with main (38f7270)

Summary

⚡ 4 improvements
❌ 3 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ recursive[10] 6.8 µs 6.5 µs +4.04%
❌ graph_coloring[3] 1 µs 1.1 µs -3.37%
❌ graph_coloring[4] 3.5 µs 4 µs -13.15%
⚡ permutations[5] 14.8 µs 13.9 µs +6.74%
⚡ permutations[6] 73.6 µs 66.9 µs +10.06%
❌ permutations[7] 769 µs 794.3 µs -3.19%
⚡ system_time 6.8 µs 6.6 µs +3.29%

art049
art049 requested changes Feb 13, 2025
View reviewed changes
crates/divan_compat/README.md Outdated Show resolved Hide resolved
@GuillaumeLagrange GuillaumeLagrange merged commit fd8f45d into main Feb 13, 2025
6 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the add-divan-todo branch February 13, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art049 art049 art049 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeLagrange @art049